Skip to content

[DO NOT MERGE! Work is parked currently] [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

[DO NOT MERGE! Work is parked currently] [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI #900

wants to merge 31 commits into from

Conversation

Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Feb 5, 2025 •
edited
Loading

Description

Adjusting scripts and creating assets to transform the UI elements within the Post Game scene to UIToolkit. This includes the SettingsPanelCanvas and the PostGameUICanvas

Issue Number(s)

https://jira.unity3d.com/browse/MTT-8685

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@Elfi0Kuhndorf Elfi0Kuhndorf changed the title Feat boos room post game UI settings panel Feat: UIToolkit for BossRoom > SettingsPanelCanvas Feb 5, 2025
@Elfi0Kuhndorf Elfi0Kuhndorf changed the title Feat: UIToolkit for BossRoom > SettingsPanelCanvas Feat: UIToolkit for BossRoom: PostGame UI Feb 14, 2025
@Elfi0Kuhndorf Elfi0Kuhndorf changed the title Feat: UIToolkit for BossRoom: PostGame UI [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI Feb 14, 2025
Elfi0Kuhndorf and others added 16 commits February 14, 2025 16:32
@Elfi0Kuhndorf
fix: add messageFeed UI, cleanup scripts, rename Prefabs
f6db0cc
@Elfi0Kuhndorf
Fix: add SettingsPanelCanvasUITK to PostGameState prefab and fix comp…
5cd1a22 
…onent assignment in script
@Elfi0Kuhndorf
WIP adding message feed functionality
a51b164 
not fully working yet
@Elfi0Kuhndorf
WIP: adjustments for MessageFeed (functionality within one new script…
d75a01f 
…) and trying to get injection of PostGameUI to work
@fernando-cortez
registration of components to the scene state context builder
815effe
@Elfi0Kuhndorf
fix: changing styling, layering and size of settingPanelCanvasUITK UI…
1e01173 
… elements; fixing naming and button execution in scripts
@Elfi0Kuhndorf
fix: fixing new MessageFeed so it displays messages dynamically
ba5336d
@Elfi0Kuhndorf
feat: add fly in animation to message feed messaged
224e28c
@Elfi0Kuhndorf
fix: remove unneeded message feed scripts
5fbb0f9
@kalmanbalint
cleanup
2f565c9
@kalmanbalint
deleting some code
65ed04f 
add changes to uss
@kalmanbalint
update
ca29629
@kalmanbalint
cleanup
969aa22
@Elfi0Kuhndorf
Debugging and adjusting fade-in animation as well as moving message f…
bc22328 
…eed uxml into post game uxml
@Elfi0Kuhndorf
Fix: adding SettingPanelCanvasUITK to all relevant scene states and s…
0fdffa8 
…cenes, removing scroller from message feed, adding delay for fadoutAnim and cleaning up code
@Elfi0Kuhndorf
Merge branch 'UTIK_suggestions' into feat_boss_room_PostGameUI_settin…
46076cc 
…gsPanel
@unity-cla-assistant
Copy link

unity-cla-assistant commented Feb 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this Feb 28, 2025
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review February 28, 2025 13:57
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner February 28, 2025 13:57
kalmanbalint
kalmanbalint requested changes Feb 28, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all great work!
there are a few nit pick I have, feel free to disregard those
the only real issue I see is the bug with the ListView control and the animations related to the message items, which I am to blame for 😅

kalmanbalint
kalmanbalint previously approved these changes Mar 3, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Elfi0Kuhndorf Elfi0Kuhndorf changed the title [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI [DO NOT MERGE! Work is parked currently] [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalmanbalint kalmanbalint kalmanbalint left review comments

@hammerlerobi hammerlerobi Awaiting requested review from hammerlerobi

At least 1 approving review is required to merge this pull request.

Assignees

@Elfi0Kuhndorf Elfi0Kuhndorf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Elfi0Kuhndorf @unity-cla-assistant @kalmanbalint @fernando-cortez